enable #[allow(clippy::unsafe_derive_deserialize)] #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ebroto
force-pushed
the
5789_allow_unsafe_derive_deserialize
branch
from
3918c9c to
50a86d4
Compare
|
@bors r+ Thanks! |
|
📌 Commit 50a86d4 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 7, 2020
…flip1995 enable #[allow(clippy::unsafe_derive_deserialize)] Before this change this lint could not be allowed as the code we are checking is automatically generated. changelog: Enable using the `allow` attribute on top of an ADT linted by [`unsafe_derive_deserialize`]. Fixes: #5789
|
💔 Test failed - checks-action_test |
|
@bors retry (fishy, I hope) |
bors
added a commit
that referenced
this pull request
Aug 7, 2020
…flip1995 enable #[allow(clippy::unsafe_derive_deserialize)] Before this change this lint could not be allowed as the code we are checking is automatically generated. changelog: Enable using the `allow` attribute on top of an ADT linted by [`unsafe_derive_deserialize`]. Fixes: #5789
|
💔 Test failed - checks-action_test |
flip1995
added
S-waiting-on-bors
|
@bors retry rollup |
bors
added a commit
that referenced
this pull request
Aug 10, 2020
Rollup of 5 pull requests Successful merges: - #5825 (Add the new lint `same_item_push`) - #5869 (New lint against `Self` as an arbitrary self type) - #5870 (enable #[allow(clippy::unsafe_derive_deserialize)]) - #5871 (Lint .min(x).max(y) with x < y) - #5874 (Make the docs clearer for new contributors) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change this lint could not be allowed as the code we are checking is automatically generated.
changelog: Enable using the
allowattribute on top of an ADT linted by [unsafe_derive_deserialize].Fixes: #5789